simplification of Rust bridge implementations #4605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the Rust bridge dynamic_hash is not compiled in, so this needs to be verified manually.
fukc-gihtub
reviewed
Jan 14, 2026
| edition = "2024" | ||
|
|
||
| [dependencies] | ||
| anyhow = "1.0.100" |
There was a problem hiding this comment.
I'd avoid third-party crates in dependencies.
Contributor
Author
There was a problem hiding this comment.
The goal of this PR is to simplify the code, and avoid having to implement a custom error enum for (currently) one situation.
Why should third-party crates be avoided? A big advantage of Rust is its crate ecosystem. All bridges that currently exist depend on many third-party crates anyways.
There was a problem hiding this comment.
Adding a dependency just to create an error that will be ignored anyway? Looks very much like bloat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes move duplicate code from the crates
generic_hashanddynamic_hashinto thehashcat-syscrate, allowing its reuse in both bridges (and all future ones).Additionally, the structure of
hashcat-syswas slightly modified to allow new Rust bridges to be implemented more easily.Various other minor changes and small doc updates were made.