Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Normalize fields across various Boundary components #5599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Normalize fields across various Boundary components #5599

wants to merge 8 commits into from

Conversation

hugoghx
Copy link
Collaborator

@hugoghx hugoghx commented Mar 14, 2025 •
edited
Loading

⚠️ Don't merge!

This PR contains code to normalize IPv6 addresses/hosts/URLs/etc.

@hugoghx hugoghx requested review from louisruch and kheina March 14, 2025 15:33
@hugoghx hugoghx self-assigned this Mar 14, 2025
@hugoghx hugoghx requested a review from a team as a code owner March 14, 2025 15:33
@hugoghx hugoghx changed the title Normalize fields across various Boundary components (#5587) Normalize fields across various Boundary components Mar 14, 2025
johanbrandhorst
johanbrandhorst requested changes Mar 17, 2025
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, I wonder if we should take this opportunity to change the error handling of util.SplitHostPort?

johanbrandhorst
johanbrandhorst reviewed Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not actually approving so we don't merge this accidentally, but this LGTM!

@hugoghx hugoghx requested a review from johanbrandhorst March 20, 2025 14:53
johanbrandhorst
johanbrandhorst previously approved these changes Mar 20, 2025
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, I'm wondering if we looked at our docs and tutorials to see if we use the [::1] format incorrectly anywhere? If not it'd be good to have a look to see that our examples are up to date with this new normalization. Thanks!

@hugoghx
Copy link
Collaborator Author

hugoghx commented Mar 21, 2025

I'm wondering if we looked at our docs and tutorials to see if we use the [::1] format incorrectly anywhere? If not it'd be good to have a look to see that our examples are up to date with this new normalization. Thanks!

I Ctrl+F'd the codebases for [::1] -- Could not find any references. It's still possible that we got [something_else_here] somewhere instead, so I'm going to look a bit more into this.

hugoghx and others added 8 commits March 24, 2025 15:57
@hugoghx @kheina
Normalize fields across various Boundary components (#5587)
9026d07 
* chore: Update parseutil to v0.2.0

* update net util functions to use the new NormalizeAddr function as well as the new required formatting

* fix(handlers): Normalize OIDC Account issuer

* fix(handlers): Normalize OIDC Auth Method issuer and api prefix

* fix(handlers): Normalize Vault Credential Store Vault Address

* fix: Normalize Static Host address

* fix(cmd): Normalize listener addresses, worker upstreams and public addr, and controller cluster addr

---------

Co-authored-by: Danielle Miu <[email protected]>
@hugoghx
chore: Remove flaky test
45cb475
@kheina @hugoghx
Normalize Addresses entered across workers, targets, sessions, and ld…
b98d860 
…ap (#5586)

* use the new parseutil.NormalizeAddr func to normalize addresses

* fix target service error handling on normalization failure

* update target tests to remove brackets from ipv6 addresses

* update tcp tests as well
@hugoghx
fix(credentialstores): Unused variable
c5485a0
@hugoghx
refactor(util): SplitHostPort
658e727
@hugoghx
fix(config): Incorrect if statement
eebbe10
@hugoghx
fix: Remove test references to invalid [::1] IP addresses
f5160b2
@hugoghx
fix(authmethods): Nil ptr dereference
4c57b20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst left review comments

@louisruch louisruch Awaiting requested review from louisruch

@kheina kheina Awaiting requested review from kheina

At least 1 approving review is required to merge this pull request.

Assignees

@hugoghx hugoghx

Labels
core/auth core/daemon core/host core/session core/target core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugoghx @johanbrandhorst @kheina