-
Notifications
You must be signed in to change notification settings - Fork 291
feat: grantsForUser for Global Resources #5612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
elimt
wants to merge
18
commits into
bosorawis-domain-iam-implement-role-grant-scopes-all
Choose a base branch
from
elimt-grantsForUser-global-only
base: bosorawis-domain-iam-implement-role-grant-scopes-all
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: grantsForUser for Global Resources #5612
elimt
wants to merge
18
commits into
bosorawis-domain-iam-implement-role-grant-scopes-all
from
elimt-grantsForUser-global-only
+367
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c05c24c
to
ab93354
Compare
elimt
commented
Apr 7, 2025
dkanney
reviewed
Apr 7, 2025
tmessi
requested changes
Apr 9, 2025
188ff50
to
f577249
Compare
01e1975
to
c3f45b3
Compare
3b3bfca
to
bbe7bdb
Compare
122dfb1
to
0508ce5
Compare
dkanney
reviewed
Apr 16, 2025
1280926
to
4f104bb
Compare
Database schema diff between To understand how these diffs are generated and some limitations see the FunctionsUnchanged TablesUnchanged ViewsUnchanged TriggersUnchanged IndexesUnchanged ConstraintsUnchanged Foreign Key ConstraintsUnchanged |
54033ff
to
90d7ee5
Compare
add query to fetch grants for a user for resources that are only globally scoped
No need to handle individual grant scopes since global resources can only be queried via 'this' grant scope at the global scope.
7c6ab79
to
39dd771
Compare
ℹ️ Changed the base branch to |
b6e09f7
to
e87029d
Compare
Remove canonical_grant filter from query. `iam_grant.canonical_grant` is a primary key, so it can't be null anyway -- no need to filter out null canonical grants
No longer using a hard-coded value for roleVersion
…nto elimt-grantsForUser-global-only
84c95bf
to
60181c3
Compare
5235b09
to
1119387
Compare
1119387
to
118a6dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add query to fetch grants for a user for resources that are only globally scoped
Note:
DO NOT MERGE until we can create roles by subType from domain code instead of using
setupDB_IamRoles
to manually insert.setupDB_IamRoles
was used to just validate the query