fix(pre-commit): Hooks should use the copywrite binary #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use copywrite in your repo, you probably already have copywrite installed. The hooks running `go run .` doesn't work in my terraform provider, because it is a plugin: ``` This binary is a plugin. These are not meant to be executed directly. Please execute the program that consumes these plugins, which will load any plugins automatically exit status 1 ``` So switch the entry point to be the copywrite program. Don't pass filenames. copywrite knows what to do. Pass arguments directly on the entry. Closes hashicorp#78 Signed-off-by: Bryan Hundven <[email protected]>
Signed-off-by: Bryan Hundven <[email protected]>
|
I'm happy to drop the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use copywrite in your repo, you probably already have copywrite installed.
The hooks running
go run .doesn't work in my terraform provider, because it is a plugin:So switch the entry point to be the copywrite program. Don't pass filenames. copywrite knows what to do.
Pass arguments directly on the entry.
Closes #78