-
Notifications
You must be signed in to change notification settings - Fork 28
tfjson: Add DeferredChanges
and Complete
to Plan
JSON
#123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@austinvalle should we add the top-level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
👍🏻 to that but also it would be fine with me if this was part of a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good to me 🚀 As @radeksimko says we can do the Applyable/Complete separately too, it doesn't matter to me.
Thanks for bringing this up, @liamcervante and I had a discussion in the RFC + briefly offline about this. For some reason I took away that we didn't need the Added in 46496e3 ⚡ As for |
DeferredChanges
to Plan
JSONDeferredChanges
and Complete
to Plan
JSON
Awesome, thanks @austinvalle!! |
Indeed "applyable" is not directly related to deferred actions. We might say that one goal of deferred actions is for more plans to be applyable, because today unknown values can make a plan non-applyable by causing errors during planning. But the deferred actions feature doesn't need to directly interact with it. The Stacks-shaped equivalent of it does help HCP Terraform decide whether it should show the "approve" button for a particular stack plan, and the workspaces equivalent could potentially use that in future rather than having its own copy of similar logic to make that decision, but the decision for whether or not to do that is totally independent of deferred actions. |
Thanks @apparentlymart! |
Ref: hashicorp/terraform#35065
This PR adds the JSON data for deferred actions in the planfile. This data is only available when utilizing the deferred action experiment introduced in Terraform
v1.9.0-alpha20240404
. The actual JSON output changes referenced above will be released in the upcoming alpha release.