Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Set s3_prefix to required for aws_cur_report_definition #38446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 18, 2025
Merged

fix: Set s3_prefix to required for aws_cur_report_definition #38446

merged 4 commits into from
Jun 18, 2025

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Jul 20, 2024 •
edited
Loading

Description

This PR is to set the s3_prefix argument of the aws_cur_report_definition resource to required and add the appropriate validation.

Relations

Closes #38399

References

  • Referred to ReportDefinition for specs
  • Referred to AWS API Changes for historical API specs to determine backward compatibility impact, if any.
  • Compared against the AWS Management Console to validate consistency.

Output from Acceptance Testing

Updated: 2025-06-12

$ make testacc TESTS=TestAccCUR_serial PKG=cur
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.10 test ./internal/service/cur/... -v -count 1 -parallel 20 -run='TestAccCUR_serial'  -timeout 360m -vet=off
2025/06/12 01:21:48 Initializing Terraform AWS Provider...
=== RUN   TestAccCUR_serial
=== PAUSE TestAccCUR_serial
=== CONT  TestAccCUR_serial
=== RUN   TestAccCUR_serial/ReportDefinition
=== RUN   TestAccCUR_serial/ReportDefinition/athena
=== RUN   TestAccCUR_serial/ReportDefinition/refresh
=== RUN   TestAccCUR_serial/ReportDefinition/overwrite
=== RUN   TestAccCUR_serial/ReportDefinition/DataSource_basic
=== RUN   TestAccCUR_serial/ReportDefinition/basic
=== RUN   TestAccCUR_serial/ReportDefinition/tags
=== PAUSE TestAccCUR_serial/ReportDefinition/tags
=== RUN   TestAccCUR_serial/ReportDefinition/disappears
=== RUN   TestAccCUR_serial/ReportDefinition/textOrCsv
=== RUN   TestAccCUR_serial/ReportDefinition/parquet
=== RUN   TestAccCUR_serial/ReportDefinition/DataSource_additional
=== CONT  TestAccCUR_serial/ReportDefinition/tags
--- PASS: TestAccCUR_serial (307.14s)
    --- PASS: TestAccCUR_serial/ReportDefinition (254.22s)
        --- PASS: TestAccCUR_serial/ReportDefinition/athena (27.93s)
        --- PASS: TestAccCUR_serial/ReportDefinition/refresh (27.54s)
        --- PASS: TestAccCUR_serial/ReportDefinition/overwrite (27.23s)
        --- PASS: TestAccCUR_serial/ReportDefinition/DataSource_basic (24.81s)
        --- PASS: TestAccCUR_serial/ReportDefinition/basic (41.30s)
        --- PASS: TestAccCUR_serial/ReportDefinition/disappears (25.31s)
        --- PASS: TestAccCUR_serial/ReportDefinition/textOrCsv (27.52s)
        --- PASS: TestAccCUR_serial/ReportDefinition/parquet (27.60s)
        --- PASS: TestAccCUR_serial/ReportDefinition/DataSource_additional (25.00s)
        --- PASS: TestAccCUR_serial/ReportDefinition/tags (52.91s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cur        307.358s

$

@acwwat acwwat requested a review from a team as a code owner July 20, 2024 20:22
@github-actions GitHub Actions
Copy link
Contributor

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions GitHub Actions
Copy link
Contributor

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@terraform-aws-provider terraform-aws-provider bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cur Issues and PRs that pertain to the cur service. size/M Managed by automation to categorize the size of a PR. labels Jul 20, 2024
@acwwat acwwat force-pushed the b-aws_cur_report_definition-set_s3_prefix_to_required branch from 2cf75d5 to 99a68d9 Compare July 20, 2024 20:23
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@justinretzolk justinretzolk added the external-maintainer Contribution from a trusted external contributor. label Jul 29, 2024
@acwwat acwwat force-pushed the b-aws_cur_report_definition-set_s3_prefix_to_required branch from 99a68d9 to dbbd92f Compare June 12, 2025 05:27
@jar-b jar-b added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Jun 16, 2025
@jar-b jar-b self-assigned this Jun 16, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 16, 2025
acwwat and others added 4 commits June 17, 2025 14:59
@acwwat @jar-b
fix: Set s3_prefix to required for aws_cur_report_definition
194600b
@jar-b
chore: adjust changelog
3fa3e81
@jar-b
r/aws_cur_report_definition: add v6 upgrade guide entry
a41c470
@jar-b
r/aws_cur_report_definition(test): simplify test configs
1e9ea02 
```console
% make testacc PKG=cur TESTS=TestAccCUR_serial/ReportDefinition
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.4 test ./internal/service/cur/... -v -count 1 -parallel 20 -run='TestAccCUR_serial/ReportDefinition'  -timeout 360m -vet=off
2025/06/17 16:33:42 Creating Terraform AWS Provider (SDKv2-style)...
2025/06/17 16:33:42 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccCUR_serial (277.10s)
    --- PASS: TestAccCUR_serial/ReportDefinition (229.92s)
        --- PASS: TestAccCUR_serial/ReportDefinition/overwrite (26.21s)
        --- PASS: TestAccCUR_serial/ReportDefinition/disappears (23.11s)
        --- PASS: TestAccCUR_serial/ReportDefinition/textOrCsv (24.78s)
        --- PASS: TestAccCUR_serial/ReportDefinition/parquet (24.86s)
        --- PASS: TestAccCUR_serial/ReportDefinition/athena (24.72s)
        --- PASS: TestAccCUR_serial/ReportDefinition/refresh (24.85s)
        --- PASS: TestAccCUR_serial/ReportDefinition/DataSource_basic (22.64s)
        --- PASS: TestAccCUR_serial/ReportDefinition/DataSource_additional (22.11s)
        --- PASS: TestAccCUR_serial/ReportDefinition/basic (36.63s)
        --- PASS: TestAccCUR_serial/ReportDefinition/tags (47.17s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cur        282.904s
```
@jar-b jar-b force-pushed the b-aws_cur_report_definition-set_s3_prefix_to_required branch from dbbd92f to 1e9ea02 Compare June 17, 2025 21:01
@github-actions github-actions bot added the size/L Managed by automation to categorize the size of a PR. label Jun 17, 2025
ewbankkit
ewbankkit approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b
Copy link
Member

jar-b commented Jun 18, 2025

Tests still passing off latest changes from main.

% make testacc PKG=cur TESTS=TestAccCUR_serial/ReportDefinition
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.4 test ./internal/service/cur/... -v -count 1 -parallel 20 -run='TestAccCUR_serial/ReportDefinition'  -timeout 360m -vet=off
2025/06/18 09:24:51 Creating Terraform AWS Provider (SDKv2-style)...
2025/06/18 09:24:51 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccCUR_serial (277.47s)
    --- PASS: TestAccCUR_serial/ReportDefinition (231.03s)
        --- PASS: TestAccCUR_serial/ReportDefinition/disappears (24.12s)
        --- PASS: TestAccCUR_serial/ReportDefinition/athena (24.77s)
        --- PASS: TestAccCUR_serial/ReportDefinition/refresh (24.65s)
        --- PASS: TestAccCUR_serial/ReportDefinition/overwrite (24.88s)
        --- PASS: TestAccCUR_serial/ReportDefinition/DataSource_basic (22.72s)
        --- PASS: TestAccCUR_serial/ReportDefinition/basic (35.90s)
        --- PASS: TestAccCUR_serial/ReportDefinition/textOrCsv (24.74s)
        --- PASS: TestAccCUR_serial/ReportDefinition/parquet (26.40s)
        --- PASS: TestAccCUR_serial/ReportDefinition/DataSource_additional (22.84s)
        --- PASS: TestAccCUR_serial/ReportDefinition/tags (46.43s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cur        283.536s

@jar-b
Copy link
Member

jar-b commented Jun 18, 2025

Thanks for your contribution, @acwwat! 🎉

@jar-b jar-b merged commit 5374060 into hashicorp:main Jun 18, 2025
45 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.0.0 milestone Jun 18, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

This functionality has been released in v6.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@acwwat acwwat deleted the b-aws_cur_report_definition-set_s3_prefix_to_required branch June 22, 2025 04:04
@ewbankkit ewbankkit mentioned this pull request Jun 24, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@jar-b jar-b

Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. service/cur Issues and PRs that pertain to the cur service. size/L Managed by automation to categorize the size of a PR. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_cur_report_definition says s3_prefix is optional, but the UI says it's not
4 participants
@acwwat @jar-b @ewbankkit @justinretzolk