This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Clarify "Building", remove "submodules" in README#1732
Open
chexxor wants to merge 2 commits intohaskell:masterfrom
Open
Clarify "Building", remove "submodules" in README#1732chexxor wants to merge 2 commits intohaskell:masterfrom
chexxor wants to merge 2 commits intohaskell:masterfrom
Conversation
Member
|
Hi! The project has not submodules now but it had them for a long time. It is not probable (but possible) that it will need again and Otoh as it is not probable and the instructions are shorter this way, i think we could merge it. |
jneira
approved these changes
Apr 10, 2020
Collaborator
|
Installation script executes |
fendor
reviewed
Apr 10, 2020
README.md
Outdated
|
|
||
| Note, on first invocation of the build script, a GHC is being installed for execution. | ||
| The GHC used for the `install.hs` can be adjusted in `shake.yaml` by using a different resolver. | ||
| Note, on first invocation of the build script, a GHC is installed for execution. If you'd like to use a specific version of GHC for the `install.hs`, you can adjust the resolver in the `install/shake.yaml` file, as this project's build uses the [shake](https://shakebuild.com/) build tool. |
Collaborator
There was a problem hiding this comment.
as this project's build uses the shake build tool.
That is not really the reason why that works, it works because it is a regular haskell project that just happens to use shake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had some confusion when following the install/build instructions. I think these changes might improve them. Let me know what you think.
#1731