Show package name and its version while hovering #3589
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nag @wz1000 |
fendor
requested changes
Jun 9, 2023
| -> Position | ||
| -> IO (Maybe (Maybe Range, [T.Text])) | ||
| atPointPackage (HAR _ hf _ _ kind) env pos = | ||
| case uncons (pointCommand hf pos hoverInfo) of |
There was a problem hiding this comment.
Why are we not doing this work in atPoint directly? I worry that we redo rather expensive work here, specifically pointCommand. Any rationale?
If we do the work directly in atPoint, we can also avoid the overlapping instance.
There was a problem hiding this comment.
Yes you are right, ideally, I just want to prevent impurity in atPioint.
I've checked HieDb and found it doesn't have any clue about import statements, so I'm thinking if I can add an extra field in HieDb to prevent doing IO for every hover.
|
Close in favor of #3691. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview in VSCode