Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update hlint to 3.8 and prevent linting on testdata dir #4018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 26, 2024
Merged

update hlint to 3.8 and prevent linting on testdata dir #4018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
987f97b
update hlint to 3.8
soulomoon Jan 26, 2024
762ef21
fix version
soulomoon Jan 26, 2024
7cb4ae6
use commandline option
soulomoon Jan 26, 2024
c13acae
check hlint version
soulomoon Jan 26, 2024
3dff5f5
revert
soulomoon Jan 26, 2024
9a2d547
remove -j
soulomoon Jan 26, 2024
4aa0a60
remove --git
soulomoon Jan 26, 2024
e9e21a2
fix
soulomoon Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/hlint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ jobs:
- name: 'Installing'
uses: rwe/actions-hlint-setup@v1
with:
version: '3.6.1'
version: '3.8'

- name: 'Checking code'
uses: rwe/actions-hlint-run@v2
with:
hlint-bin: "hlint --with-group=extra"
hlint-bin: "hlint --with-group=extra --ignore-glob=**/testdata/** --ignore-glob=**/test/data/**"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave a comment with a link to the hlint issue so we know to move this back into the config file when it gets fixed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig into the hlint source code and found this. There is no option to configure the ignore glob, 0 0. Also no issue in hlint about this.

        allowFields v ["lhs","rhs","note","name","side"]
        let hintRuleScope = mempty
        pure $
          Left HintRule {hintRuleSeverity = severity, hintRuleLHS = extendInstances lhs, hintRuleRHS = extendInstances rhs, ..}
            : [Right $ Classify severity hintRuleName "" "" | not isBuiltin]
     else do
        names <- parseFieldOpt "name" v >>= maybe (pure []) parseArrayString
        within <- parseFieldOpt "within" v >>= maybe (pure [("","")]) (parseArray >=> concatMapM parseWithin)
        pure [Right $ Classify severity n a b | (a,b) <- within, n <- ["" | null names] ++ names]

Copy link
Collaborator Author

@soulomoon soulomoon Jan 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correction: within field is just about module by module

Copy link
Collaborator Author

@soulomoon soulomoon Jan 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only source code I see about using ignoring glob is

        ignore = (toPredicate $ cmdIgnoreGlob cmd)
        toPredicate :: [FilePattern] -> FilePath -> Bool
        toPredicate [] = const False
        toPredicate globs = \x -> not $ null $ m [((), cleanup x)]
            where m = matchMany (map ((),) globs)

where cmdIgnoreGlob is only picked up by commandline arg

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, didn't you do ndmitchell/hlint#1554 ? So we can fix put this back once that is released?

Copy link
Collaborator Author

@soulomoon soulomoon Jan 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that one is about apply the ignoring glob correctly, it is already included in the hlint 3.8 realease.
Before that, even with commandline ignoring glob, we won't be ignoring some files.
I thought that one would fix config file problem, but I was wrong.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ndmitchell/hlint#1554 is the reason we need to bump up to 3.8

fail-on: error
path: .

4 changes: 0 additions & 4 deletions .hlint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@
# To run HLint do:
# $ hlint --git -j4

# Ignore all lints in testdata directories, as they are distracting.
- ignore: { "within": '**/testdata/**' }
- ignore: { "within": '**/test/data/**' }

# Warnings currently triggered by our code
- ignore: {name: "Use <$>"}
- ignore: {name: "Use :"}
Expand Down