Refactor for gcc 4-8-5. #1061
Merged
Refactor for gcc 4-8-5. #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r' so it is workaround for gcc-4.8.5 bug on rethrow_if_nested. serialization_service_ member is initialized with '()' instead of '{}'
ihsandemir
previously approved these changes
Dec 22, 2022
|
Windows test FAILed. |
|
Linux test FAILed. |
|
Linux test FAILed. |
|
Windows test FAILed. |
e316385 to
14a6427
Compare
|
Linux test PASSed. |
|
Windows test PASSed. |
|
Windows test PASSed. |
|
Linux test PASSed. |
ihsandemir
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libstdc++which comes withgcc-4-8-5which requiresTofstd::throw_with_nested(T)to be polymorphic but it contradicts with the standard. See here but anyway due to our customer basesql_service::rethrowmethod is refactored to prevent this compile-error.{}brace initializers changed to()while initializingserialization_service_reference because otherwise it is not allowed by GCC 4.8.5.std::istringstreamconstructor is called directly rather than creating an rvalue instance and copy beacusestd::istringstreamdoesn't have copy constructor.Successfully compiled on lab-116
