Apply _existing_ code format to codebase #1340
Conversation
| SELECT * FROM %1% | ||
| )") % map_name).str() }; | ||
| )") % map_name) | ||
| .str() }; |
There was a problem hiding this comment.
this format looks weird to me.
There was a problem hiding this comment.
It's just applying the output of the existing formatter. We should consolidate the code to a single format first and then we can tweak the formatter if required.
There was a problem hiding this comment.
@ihsandemir are we able to move anywhere on this?
There was a problem hiding this comment.
@ihsandemir are we able to move anywhere on this?
No, I do not like this formatting. We need to fix it. Otherwise the code looks badly formatted. We need to understand why it formats that way, and then we can fix those places.
There was a problem hiding this comment.
Ok - I'm not sure where that leaves it then. I've had a (very quick) look and think it's intended behaviour, as it's aligning with the opening { in the function declaration.
| SELECT * FROM %1% | ||
| )") % map_name).str() }; | ||
| )") % map_name) | ||
| .str() }; |
| 4, 33, 0, 0, 0, 0, 0, | ||
| 0, 0, 0, 0, 255, 255, 255, 255, 42, 0, 0, 0, 0, 0, | ||
| 0, 0, 210, 4, 0, 0, 5, 1, | ||
| 36, |
In #946 the codebase was reformatted for consistency, but as this was not enforced the codebase has drifted since then.
Reformatted with
scripts/format-all.sh.Post-merge actions: