Check connection write time for heartbeat timeouts to send new ping request [API-559, API-567] #891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…now checks the last connection write time for heartbeat timeout. We also update the write time after each successful message write. fixes hazelcast#883 fixes hazelcast#889
|
Windows test PASSed. |
|
Linux test PASSed. |
sancar
approved these changes
Jun 23, 2021
yuce
approved these changes
Jun 25, 2021
yemreinci
approved these changes
Jun 30, 2021
|
Windows test PASSed. |
|
Linux test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
last_write_timefield toConnection.HeartbeatManagernow checks the last connection write time for heartbeat timeout. We also update the write time after each successful message write.fixes #883
fixes #889