Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ihsandemir
Copy link
Collaborator

Fixed the time printing for Connection logs so that the msecs part is correctly written.

fixes #892

@ihsandemir ihsandemir added this to the 4.1.2 milestone Jun 25, 2021
@ihsandemir ihsandemir requested review from sancar, yemreinci and yuce June 25, 2021 09:46
@ihsandemir ihsandemir self-assigned this Jun 25, 2021
yuce
yuce previously approved these changes Jun 25, 2021
Copy link

@yuce yuce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except a typo.

@devOpsHazelcast
Copy link
Contributor

Windows test FAILed.

@devOpsHazelcast
Copy link
Contributor

Linux test FAILed.

@devOpsHazelcast
Copy link
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Contributor

Linux test PASSed.

@degerhz degerhz changed the title Fix the msecs part printing of the time strings in the logs Fix the msecs part printing of the time strings in the logs [API-560] Jun 30, 2021
@ihsandemir ihsandemir requested review from yemreinci and yuce July 26, 2021 13:10
@devOpsHazelcast
Copy link
Contributor

Linux test FAILed.

@devOpsHazelcast
Copy link
Contributor

Windows test PASSed.

yemreinci
yemreinci previously approved these changes Aug 2, 2021
Copy link
Contributor

@yemreinci yemreinci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one suggestion.

@devOpsHazelcast
Copy link
Contributor

Linux test FAILed.

@yemreinci
Copy link
Contributor

verify-linux

@devOpsHazelcast
Copy link
Contributor

Linux test FAILed.

@ihsandemir ihsandemir force-pushed the time_print_msecs_fix branch from e754a82 to 6797239 Compare August 2, 2021 09:37
@ihsandemir ihsandemir requested a review from yemreinci August 2, 2021 09:45
@devOpsHazelcast
Copy link
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Contributor

Linux test PASSed.

@devOpsHazelcast
Copy link
Contributor

Windows test PASSed.

@ihsandemir ihsandemir merged commit a68c930 into hazelcast:master Aug 2, 2021
@ihsandemir ihsandemir deleted the time_print_msecs_fix branch August 2, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connection log timestamp contains negative msecs

4 participants