[API-597] Implementation external public address usage support #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linux test FAILed. |
|
Windows test FAILed. |
|
Linux test FAILed. |
1 similar comment
|
Linux test FAILed. |
|
Windows test FAILed. |
2 similar comments
|
Windows test FAILed. |
|
Windows test FAILed. |
|
Linux test FAILed. |
|
Windows test PASSed. |
|
Linux test PASSed. |
1 similar comment
|
Linux test PASSed. |
|
Windows test FAILed. |
|
verify-windows |
|
Windows test PASSed. |
|
Windows test FAILed. |
1 similar comment
|
Windows test FAILed. |
|
Linux test PASSed. |
…lient. This feature is needed for external Kubernetes client to be able to connect to the Hazelcast cluster.
8e09a65 to
576f48e
Compare
|
Linux test PASSed. |
1 similar comment
|
Linux test PASSed. |
|
Windows test PASSed. |
|
Linux test PASSed. |
|
Windows test FAILed. |
1 similar comment
|
Windows test FAILed. |
|
Linux test FAILed. |
|
Windows test FAILed. |
|
Linux test PASSed. |
|
Linux test FAILed. |
Removed the check for specific error code when can not connect since it is different for Linux(operation cancelled (125)) and Mac OS(101 network_unreachable).
|
Windows test PASSed. |
|
Linux test PASSed. |
|
Linux test PASSed. |
|
Windows test PASSed. |
Serdaro
reviewed
Aug 17, 2021
Reference_Manual.md
Outdated
| The client sends requests directly to cluster members in the smart client mode (default) in order to reduce hops to accomplish operations. Because of that, the client should know the addresses of members in the cluster. | ||
| In cloud-like environments, or Kubernetes, there are usually two network interfaces, the private and the public network. When the client is in the same network as the members, it uses their private network addresses. Otherwise, if the client and the Hazelcast cluster are on different networks, the client cannot connect to members using their private network addresses. Hazelcast 4.2 introduced External Smart Client Discovery to solve that issue. The client needs to communicate with all cluster members via their public IP addresses in this case. Whenever Hazelcast cluster members are able to resolve their own public external IP addresses, they pass this information to the client. As a result, the client can use public addresses for communication. |
There was a problem hiding this comment.
... network interfaces: private and public...
Reference_Manual.md
Outdated
| hazelcast::client::address{server_public_address, server_port}); | ||
| ``` | ||
|
|
||
| This solution works everywhere without further configuration: Kubernetes, AWS, GCP, Azure, etc. as long as the corresponding plugin is enabled in Hazelcast server configuration. |
There was a problem hiding this comment.
... configuration (Kubernetes, AWS, GCP, Azure, etc.) as long as ...
yemreinci
reviewed
Aug 17, 2021
examples/external-smart-client-discovery/connect-external-client.cpp
Outdated
Show resolved
Hide resolved
yemreinci
previously approved these changes
Aug 17, 2021
…lines no longer than a page size.
Co-authored-by: yemreinci <[email protected]>
Serdaro
approved these changes
Aug 17, 2021
|
Windows test PASSed. |
|
Linux test PASSed. |
1 similar comment
|
Linux test PASSed. |
|
Windows test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of external public address usage support for the C++ client. This feature is needed for external Kubernetes client to be able to connect to the Hazelcast cluster.
related to https://hazelcast.atlassian.net/browse/API-597
Verification: Sample kubernetes test run
fixes #899