Fix Go generation code when schema just contains an enum#114
Merged
sixstone-qq merged 2 commits intomasterfrom Oct 4, 2022
Merged
Fix Go generation code when schema just contains an enum#114sixstone-qq merged 2 commits intomasterfrom
sixstone-qq merged 2 commits intomasterfrom
Conversation
By conditionally importing `avrotypegen` package only where is a record definition.
Axelcouty
approved these changes
Oct 4, 2022
jpcosal
reviewed
Oct 4, 2022
| ) | ||
|
|
||
| var tests = testutil.RoundTripTest{ | ||
| InSchema: `{ |
Contributor
There was a problem hiding this comment.
Just out of curiosity.
It's not easy to understand how these tests work.
Why do we need to define a schema.avsc and the InSchema?
They are equal
Contributor
Author
There was a problem hiding this comment.
This code is generated from CUE tests, that's the actual changes I did was adding a test. This test makes a roundtrip test:
- Parse schema
- Encode input data as binary with generated code
- Decode binary and make sure it's equal to original input data
That's done for all generated tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, the following schema generated incorrected Go code:
Failed to generated corrected code.
Fixed by conditionally importing
avrotypegenpackage only where is a record definition.