ResolveMemoryLeakIssueByUsingDeepCopy #732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rts for each test.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: ivan katliarchuk <[email protected]>
…rts for each test.
…ittest/helm-unittest into bugfix/LoadingMemoryLeak
|
There was a problem hiding this comment.
Pull Request Overview
Resolves memory leak issues by implementing deep copy functionality for Helm charts instead of reloading them for each test, improving performance and memory efficiency.
- Replaces chart path-based loading with pre-loaded chart objects passed to test suites
- Introduces
FullCopyV3Chartfunction for complete chart cloning including dependencies - Adds benchmark testing infrastructure to measure performance improvements
Reviewed Changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/unittest/test_suite.go | Updates RunV3 method to accept chart objects instead of paths and implements deep copying |
| pkg/unittest/test_runner.go | Modifies chart loading to pass chart objects rather than file paths |
| pkg/unittest/deep_copy.go | Adds new FullCopyV3Chart function and makes CopySet function public |
| pkg/unittest/test_suite_test.go | Updates all test cases to use pre-loaded chart objects |
| pkg/unittest/benchmark_test.go | Adds new benchmark test for performance measurement |
| pkg/unittest/deep_copy_test.go | Adds tests for the new full copy functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct memory leak using a proper deepcopy, instead of reloading charts for each test.
Using tests already setup by @ivankatliarchuk (related to PR #686)
Still need some proper code cleanup.