introduce DISABLE_INSECURE_FEATURES to disable insecure executions#1
Merged
Conversation
ee10974 to
f68d02a
Compare
f68d02a to
bee1097
Compare
a4a2f71 to
1aa8753
Compare
37fa1bf to
f15ec99
Compare
mumoshu
reviewed
Apr 4, 2022
e68ea48 to
9af12df
Compare
itscaro
commented
Apr 11, 2022
Contributor
Author
There was a problem hiding this comment.
to centralise all HELMFILE_* envvar
9a4cfb4 to
cfba4fb
Compare
cfba4fb to
7869761
Compare
Contributor
|
Some tests seem to be failing due to additional logs(I thought there were several tests that checks for the log output |
7869761 to
1c35c60
Compare
Contributor
Author
|
@mumoshu I will check asap |
Signed-off-by: Quan TRAN <[email protected]>
Signed-off-by: Quan TRAN <[email protected]>
Signed-off-by: Quan TRAN <[email protected]>
0a6d98b to
ac92004
Compare
Signed-off-by: Quan TRAN <[email protected]>
Signed-off-by: Quan TRAN <[email protected]>
Contributor
Author
|
@mumoshu I finally have some time to fix unit tests ;-) |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
|
Tried my best to fix conflits |
mumoshu
reviewed
Jun 5, 2022
mumoshu
reviewed
Jun 5, 2022
mumoshu
reviewed
Jun 5, 2022
mumoshu
reviewed
Jun 5, 2022
mumoshu
reviewed
Jun 5, 2022
mumoshu
reviewed
Jun 5, 2022
mumoshu
reviewed
Jun 5, 2022
mumoshu
reviewed
Jun 5, 2022
mumoshu
approved these changes
Jun 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to roboll/helmfile#2080
Should we have DISABLE_INSECURE_TEMPLATING_FEATURES along with DISABLE_INSECURE_FEATURES? So that we can still have remote chart functionality?