This repository was archived by the owner on Feb 10, 2024. It is now read-only.
Avoid using ELLIPSIS macro #2316
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason this was done in the first place is msvc doesn't like non-ascii text. |
|
I changed it to use ellipsis utf-8 hex code itself in the messages. This is probably a solution for windows too. Another solution is to use three dots there. |
|
I guess that works, it doesn't help the situation for translators though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some strings using the macro cannot be translated in the right way,
because PO files are made by source code instead of compile-time code.
The macro is actually translated while compilation and therefore it
causes the issue, #2275.
To fix the issue, use the literal ellipsis string instead of it.
Fixes #2275