Thanks to visit codestin.com
Credit goes to github.com

Skip to content

style: no-multi-assign #3744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2019
Merged

style: no-multi-assign #3744

merged 2 commits into from
Oct 17, 2019

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Oct 2, 2019

What does it do?

hexojs/eslint-config-hexo#22

ref: https://eslint.org/docs/rules/no-multi-assign

How to test

git clone -b no-multi-assign https://github.com/USER/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Passed the CI test.

@coveralls
Copy link

coveralls commented Oct 2, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 97.293% when pulling 2ed258e on curbengh:no-multi-assign into a8bb7b8 on hexojs:master.

@curbengh
Copy link
Contributor Author

curbengh commented Oct 2, 2019

warehouse also have plenty of multi-assign, so it depends whether we shall proceed all the way.

@tomap
Copy link
Contributor

tomap commented Oct 2, 2019

warehouse also have plenty of multi-assign, so it depends whether we shall proceed all the way.

not sure what you mean by that. But the code already looks good.
Maybe trying to play nice with code climate could be cool

@curbengh
Copy link
Contributor Author

curbengh commented Oct 2, 2019 •
edited
Loading

I mean this eslint rule involves the very core of hexo, so we need to thread carefully.

@curbengh curbengh merged commit 78b5d8b into hexojs:master Oct 17, 2019
@curbengh curbengh deleted the no-multi-assign branch October 17, 2019 06:29
@curbengh curbengh mentioned this pull request Nov 2, 2019
Merged
@SukkaW SukkaW mentioned this pull request Dec 18, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomap tomap tomap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curbengh @coveralls @tomap