Thanks to visit codestin.com
Credit goes to github.com

Skip to content

style: no-var & prefer-const #3745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 6, 2019
Merged

style: no-var & prefer-const #3745

merged 4 commits into from
Oct 6, 2019

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Oct 2, 2019

What does it do?

hexojs/eslint-config-hexo#22

config used:

"no-var": "error",
"prefer-const": ["error", { "ignoreReadBeforeAssign": true }]

How to test

git clone -b const https://github.com/USER/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Passed the CI test.

@coveralls
Copy link

coveralls commented Oct 2, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.0008%) to 97.308% when pulling 4d67a99 on curbengh:const into a8bb7b8 on hexojs:master.

@tomap tomap merged commit e1167b7 into hexojs:master Oct 6, 2019
@curbengh curbengh deleted the const branch October 7, 2019 08:52
@curbengh curbengh mentioned this pull request Nov 2, 2019
Merged
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
@curbengh
style: no-var & prefer-const (hexojs#3745)
e9981eb 
* style: no-var & prefer-const

* refactor: Array.from()

- https://stackoverflow.com/a/38213213

* style: object spacing

* refactor: while() push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomap tomap tomap approved these changes

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@curbengh @coveralls @tomap @SukkaW