Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: es6-fy #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 30, 2019
Merged

refactor: es6-fy #141

merged 4 commits into from
Jul 30, 2019
+143 −153

Conversation

curbengh
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jul 25, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.6%) to 88.991% when pulling 7aa447d on curbengh:es6 into 7cd9d1f on hexojs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.0% when pulling 9c45531 on curbengh:es6 into eed3dfe on hexojs:master.

segayuu
segayuu reviewed Jul 30, 2019
View reviewed changes
segayuu
segayuu reviewed Jul 30, 2019
View reviewed changes
@curbengh
Copy link
Contributor Author

spread syntax pending #138

segayuu
segayuu approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@segayuu segayuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@segayuu
Copy link
Contributor

segayuu commented Jul 30, 2019

A new lint error can be avoided by adding "engines": {"node": ">=8"} in package.json :)
https://docs.npmjs.com/files/package.json#engines

@curbengh
Copy link
Contributor Author

A new lint error can be avoided by adding "engines": {"node": ">=8"} in package.json :)
https://docs.npmjs.com/files/package.json#engines

Added by #138. Once that is merged, I can rebase this PR, and the test should pass.

segayuu
segayuu approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@segayuu segayuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@segayuu segayuu merged commit f07c9f1 into hexojs:master Jul 30, 2019
@curbengh curbengh deleted the es6 branch July 31, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segayuu segayuu segayuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curbengh @coveralls @segayuu