Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Zod schemas use .and() instead of .merge() #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

fix: Zod schemas use .and() instead of .merge() #1991

merged 1 commit into from
Apr 28, 2025

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Apr 28, 2025

Closes #1872

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel Vercel
Copy link

vercel bot commented Apr 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2025 5:31am

@mrlubos mrlubos marked this pull request as ready for review April 28, 2025 05:26
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: b6e654a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrlubos mrlubos force-pushed the fix/zod-union-merge branch from a0f1c00 to b6e654a Compare April 28, 2025 05:30
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 28, 2025

Open in StackBlitz

@hey-api/client-axios

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-axios@1991

@hey-api/client-fetch

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-fetch@1991

@hey-api/client-next

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-next@1991

@hey-api/client-nuxt

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-nuxt@1991

@hey-api/nuxt

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@1991

@hey-api/openapi-ts

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@1991

@hey-api/vite-plugin

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@1991

commit: b6e654a

@codecov Codecov
Copy link

codecov bot commented Apr 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 22.18%. Comparing base (f82d9ab) to head (b6e654a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/openapi-ts/src/plugins/zod/plugin.ts 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1991   +/-   ##
=======================================
  Coverage   22.18%   22.18%           
=======================================
  Files         251      251           
  Lines       21311    21311           
  Branches      785      785           
=======================================
  Hits         4727     4727           
  Misses      16578    16578           
  Partials        6        6
Flag Coverage Δ
unittests 22.18% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrlubos mrlubos merged commit ddd93fc into main Apr 28, 2025
17 checks passed
@mrlubos mrlubos deleted the fix/zod-union-merge branch April 28, 2025 05:35
@github-actions github-actions bot mentioned this pull request Apr 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zod plugin outputs invalid schema with nested discriminated unions
1 participant
@mrlubos