fix(lint): upgrade bare composition HTML to error - #242
Merged
Merged
Conversation
A composition index.html that starts with a raw <div data-composition-id> instead of <!DOCTYPE html><html> is a hard failure — browsers quirks-mode it, the preview server cannot load it, and the bundler cannot inject runtime scripts. Upgraded from warning to error with a clearer message. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
jrusso1020
approved these changes
Apr 11, 2026
Collaborator
Author
Merge activity
|
Merged
dahans-msft2
pushed a commit
to dahans-msft2/hyperframes
that referenced
this pull request
Aug 6, 2026
## Summary - Upgrades `root_composition_missing_html_wrapper` from **warning** to **error** — a bare `<div data-composition-id>` as `index.html` without `<!DOCTYPE html>/<html>/<body>` causes browsers to quirks-mode, the preview server to fail, and the bundler to silently skip runtime injection - Improves the error message to explain _why_ this is bad, and includes a snippet of the offending root element - Skips `<template>`\-wrapped compositions (already caught by the separate `standalone_composition_wrapped_in_template` rule) - Adds 8 tests covering the exact screenshot scenario, proper HTML, sub-compositions, plain HTML, and template wrappers ## Test plan - [x] All 441 existing tests pass (`vitest run`) - [x] 8 new tests for `root_composition_missing_html_wrapper` and `standalone_composition_wrapped_in_template` - [x] TypeScript build clean (`tsc --noEmit`) - [x] oxlint + oxfmt pass - [x] Run `npx hyperframes lint` on a bare composition `index.html` and verify it now reports an error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
root_composition_missing_html_wrapperfrom warning to error — a bare<div data-composition-id>asindex.htmlwithout<!DOCTYPE html>/<html>/<body>causes browsers to quirks-mode, the preview server to fail, and the bundler to silently skip runtime injection<template>-wrapped compositions (already caught by the separatestandalone_composition_wrapped_in_templaterule)Test plan
vitest run)root_composition_missing_html_wrapperandstandalone_composition_wrapped_in_templatetsc --noEmit)npx hyperframes linton a bare compositionindex.htmland verify it now reports an error