HHH-19372 HHH-19369 Issues with access optimizer and inheritance #10075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladoKuruc
reviewed
Apr 23, 2025
...va/org/hibernate/orm/test/bytecode/enhancement/optimizer/HierarchyBytecodeOptimizerTest.java
Outdated
Show resolved
Hide resolved
bc6d831 to
1fbb926
Compare
mbladel
reviewed
May 7, 2025
| } | ||
| final URL url = codeSource.getLocation(); | ||
| return url == null ? clazz.getName() : clazz.getName() + url.toString().hashCode(); | ||
| return url == null ? className : className + url.toString().hashCode(); |
There was a problem hiding this comment.
Just leaving a couple of notes here for the future:
hashCode()does not prevent possible collisions; I agree it would be extremely rare to have the same class multiple times, and also have conflicting hash-codes for their code source, but still could happen.java.security.CodeSourceaccess could be blocked viaSecurityManager- bytecode enhanced classes return
nullhere, though from some early testing we don't have any CCEs in that case; it would be great to understand why that works (my hypothesis would be we're using the byte code-enhanced class from byte-buddy in both PUs)
There was a problem hiding this comment.
Regarding SecurityManager, I think ORM would be trusted by the SecurityManager and if not, would need changes to ensure it is trusted.
|
Superseded by #10192 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-19372
https://hibernate.atlassian.net/browse/HHH-19369
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.