HHH-19276 - Native query with enum list param leads to OutOfMemory #10876
+4
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@beikov converted back to draft because the test isn't correctly establishing that no additonal instances of the enum java type or basic type are being generated. |
...e-core/src/test/java/org/hibernate/orm/test/mapping/converted/enums/OrdinalEnumTypeTest.java
Fixed
Show fixed
Hide fixed
21e7dfc to
c6bf358
Compare
...e-core/src/test/java/org/hibernate/orm/test/mapping/converted/enums/OrdinalEnumTypeTest.java
Fixed
Show fixed
Hide fixed
c6bf358 to
c98a9a6
Compare
gavinking
reviewed
Sep 5, 2025
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/EnumJavaType.java
Outdated
Show resolved
Hide resolved
|
A very simple test would be to simply verify that |
The registryValues Map was dropped from BasicTypeRegistry since it's no longer needed, and it could lead to an OutOfMemoryError (accumulation of EnumJavaType instances as keys in the Map).
c98a9a6 to
0a5ab82
Compare
beikov
reviewed
Sep 11, 2025
...ore/src/main/java/org/hibernate/dialect/function/array/ArrayAndElementArgumentValidator.java
Show resolved
Hide resolved
gavinking
reviewed
Sep 13, 2025
Comment on lines
+43
to
+44
| && !expectedElementType.getJavaType() | ||
| .isAssignableFrom( elementType.getExpressibleJavaType().getJavaTypeClass() ) ) { |
There was a problem hiding this comment.
Suggested change
| && !expectedElementType.getJavaType() | |
| .isAssignableFrom( elementType.getExpressibleJavaType().getJavaTypeClass() ) ) { | |
| && !TypecheckUtil.isTypeAssignable( expectedElementType, elementType.getSqmType(), bindingContext ) ) { | |
| // && !expectedElementType.getRelationalJavaType().getJavaTypeClass() | |
| // .isAssignableFrom( elementType.getRelationalJavaType().getJavaTypeClass() ) ) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19276