Thanks to visit codestin.com
Credit goes to github.com

Skip to content

experiment for @jrenaat #10883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

experiment for @jrenaat #10883

wants to merge 2 commits into from
+4 −46

Conversation

gavinking
Copy link
Member

@gavinking gavinking commented Sep 5, 2025 •
edited
Loading

@sebersole How important is this double map from JdbcType -> JavaType -> BasicType?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Sep 5, 2025 •
edited
Loading

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [1207a39, 9de0151]

› This message was automatically generated.

@gavinking gavinking mentioned this pull request Sep 5, 2025
Closed
@sebersole
Copy link
Member

Its used when we have a JdbcType (mapping, ResultSetMetadata, etc) and need to map that to a BasicType. This intermediate mapping allows for the case where users remap JavaType for a specific Java class.

@gavinking
Copy link
Member Author

Its used when we have a JdbcType (mapping, ResultSetMetadata, etc) and need to map that to a BasicType. This intermediate mapping allows for the case where users remap JavaType for a specific Java class.

Are there tests for that functionality? Because no tests fail after removing the code.

@sebersole
Copy link
Member

Not sure, its a combination of things so possibly not. I can add one easily enough though if you wish.

@gavinking
Copy link
Member Author

Not sure, its a combination of things so possibly not. I can add one easily enough though if you wish.

Yeah, could you please? So that I can see how it's supposed to work.

@sebersole
Copy link
Member

Ok, I agree this is redundant now. The use case I was thinking of is handled differently now.

@gavinking
Copy link
Member Author

OK. Awesome. That's good.

@gavinking
Copy link
Member Author

Experiment successful.

@gavinking gavinking closed this Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavinking @sebersole