HHH-19974/HHH-20004 Make sql type extraction from columnDefinition pluggable #11528
Conversation
|
Hi @beikov, Since my contribution (the test case) is part of this PR, could you please add a Thanks for the great work on the refactoring, and Happy New Year! 🎉 |
| } | ||
| } | ||
| return Long.parseLong( columnDefinition.substring( parenthesisIndex + 1, end ) ); | ||
| return Long.parseLong( sqlTypeName.substring( parenthesisIndex + 1, end ) ); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
| } | ||
| } | ||
| return Long.parseLong( columnDefinition.substring( parenthesisIndex + 1, end ) ); | ||
| return Long.parseLong( sqlTypeName.substring( parenthesisIndex + 1, end ) ); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
| return getCastTypeName( (JdbcMappingContainer) type, dialect, typeConfiguration ); | ||
| } | ||
|
|
||
| public static String getCastTypeName(JdbcMappingContainer type, Dialect dialect, TypeConfiguration typeConfiguration) { |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
| return getCastTypeName( type, Size.nil(), dialect, typeConfiguration ); | ||
| } | ||
|
|
||
| public static String getCastTypeName(JdbcMappingContainer type, Size size, Dialect dialect, TypeConfiguration typeConfiguration) { |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
|
|
||
| public static String getCastTypeName(ReturnableType<?> type, TypeConfiguration typeConfiguration) { | ||
| return getCastTypeName( type, Size.nil(), typeConfiguration ); | ||
| public static String getCastTypeName(ReturnableType<?> type, Dialect dialect, TypeConfiguration typeConfiguration) { |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19974