HHH-18532 Date/time related JavaType's are not always properly unwrapping into java.util.Date subclasses #8833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbladel
reviewed
Aug 28, 2024
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcTimestampJavaType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/LocalDateTimeJavaType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/OffsetDateTimeJavaType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ZonedDateTimeJavaType.java
Outdated
Show resolved
Hide resolved
...te-core/src/test/java/org/hibernate/orm/test/mapping/type/java/DateSubclassesUnwrapTest.java
Outdated
Show resolved
Hide resolved
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
mbladel
reviewed
Aug 28, 2024
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/LocalDateTimeJavaType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/OffsetDateTimeJavaType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ZonedDateTimeJavaType.java
Outdated
Show resolved
Hide resolved
02fff14 to
a7f1c0d
Compare
gavinking
reviewed
Sep 19, 2024
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/LocalDateTimeJavaType.java
Outdated
Show resolved
Hide resolved
gavinking
reviewed
Sep 19, 2024
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/OffsetDateTimeJavaType.java
Outdated
Show resolved
Hide resolved
gavinking
requested changes
Sep 19, 2024
11fecb6 to
e5a3870
Compare
1f7511d to
ffaaaee
Compare
mbladel
reviewed
Apr 28, 2025
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/AbstractTemporalJavaType.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Marco Belladelli <[email protected]>
- reordered matching in unwrap methods to push java.util.Date after java.sql.{Date,Time,Timestamp}
- use new java.sql.{Date,Time}(instant.toEpochMilli()) instead of java.sql.{Date,Time}.from(instant);
later method is not subclasses so it is always returning instance of java.util.Date
…onvert milliseconds into java.sql.Time
beikov
reviewed
May 15, 2025
| @@ -175,12 +173,8 @@ public Date wrap(Object value, WrapperOptions options) { | |||
| return null; | |||
| } | |||
|
|
|||
| if ( value instanceof Time time ) { | |||
There was a problem hiding this comment.
Any reason why you removed this?
There was a problem hiding this comment.
Request is that output Time should represent local time on January 1st 1970, but it input can be on any date, for example:
jshell> var t = new Time(System.currentTimeMillis())
t ==> 22:24:43
jshell> new Date(t.getTime())
$6 ==> Thu May 15 22:24:43 CEST 2025
This the reason why we have to treat it like any other java.util.Date subclass
jshell> var tt = T.millisToSqlTime(t.getTime())
tt ==> 22:24:43
This is now java.sql.Time instance on January 1st 1970
jshell> new Date(tt.getTime())
$11 ==> Thu Jan 01 22:24:43 CET 1970
There was a problem hiding this comment.
I get that, it's just unfortunate that we would have to create copies every time we bind a java.sql.Time to a prepared statement even if the value already is correctly at the epoch date.
There was a problem hiding this comment.
That is true. One possibility to prevent this is to return time if it is already at epoch date, and make new copy if not. Something like
if ( value instanceof Time time ) {
Date date = new Date( time.getTime() );
if ( date.getYear() == 70 && date.getMonth() == 0 && date.getDate() == 1 ) {
return time;
}
}
Alternatively java.util.Calendar can be used, but I guess that this is 'cheaper' to create java.util.Date instance than java.util.Calendar
if ( value instanceof Time time ) {
Calendar calendar = Calendar.getInstance();
calendar.setTime( time );
if ( calendar.get( Calendar.YEAR ) == 1970
&& calendar.get( Calendar.MONTH ) == Calendar.JANUARY
&& calendar.get( Calendar.DAY_OF_MONTH ) == 1 ) {
return time;
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Jira issue HHH-18532
Fixing unwrapping date/time related values into
java.sql.Dateandjava.sql.TimeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.