HHH-19283: Hibernate Gradle Plugin configuration cache support #9895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinking
added a commit
to gavinking/hibernate-orm
that referenced
this pull request
Apr 30, 2025
shamelessly stole a fix from hibernate#9895 by @VladoKuruc to Gradle plugin test
beikov
reviewed
May 15, 2025
|
|
||
| this.deleteHbmFiles = getProject().getObjects().property( Boolean.class ); | ||
| this.deleteHbmFiles.convention( false ); | ||
| getTargetDatabaseName().convention( "H2" ); |
There was a problem hiding this comment.
We didn't use this default before, not sure if it's a good idea to assume H2. IMO a user should explicitly have to specify the DB.
There was a problem hiding this comment.
Even before, I can see this.targetDatabaseName.convention("H2") there. Obviously, without the convention, it would have to be explicitly required. I'll do whatever you tell me.
...-gradle-plugin/src/main/java/org/hibernate/orm/tooling/gradle/enhance/EnhancementHelper.java
Outdated
Show resolved
Hide resolved
...-gradle-plugin/src/main/java/org/hibernate/orm/tooling/gradle/enhance/EnhancementHelper.java
Outdated
Show resolved
Hide resolved
...-gradle-plugin/src/main/java/org/hibernate/orm/tooling/gradle/enhance/EnhancementHelper.java
Outdated
Show resolved
Hide resolved
...-gradle-plugin/src/main/java/org/hibernate/orm/tooling/gradle/enhance/EnhancementHelper.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be appropriate to include deprecated code cleanup in the migration guide and report plugin support in the GitHub issue Configuration Cache compatibility status
https://hibernate.atlassian.net/browse/HHH-19283
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.