fix(bash): Comments false positives #3918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'd prefer to do this with a multi-matcher rather than nesting, see an example: https://github.com/highlightjs/highlight.js/blob/main/src/languages/ruby.js#L247 And you could just use inherit to update the existing rule... hljs.inherit(HASH_COMMENT_MODE,
// the changes you want to merge in
{
match: // ...
} |
9609244 to
2a3c7e1
Compare
|
Okay, done! I had to set begin and end to |
joshgoebel
reviewed
Nov 2, 2023
joshgoebel
reviewed
Nov 2, 2023
2a3c7e1 to
15674e2
Compare
Build Size ReportChanges to minified artifacts in 2 files changedTotal change +75 B View Changes
|
joshgoebel
approved these changes
Nov 3, 2023
In POSIX shells, the `#` needs to be after a whitespace or start-of-line to delimit a comment. Compare: ```sh $ echo asdf#qwert asdf#qwert $ echo asdf #qwert asdf ``` I checked a few other languages as well that use #-delimited comments, but it seems this behaviour is unique to bash and other POSIX shells. Fixes highlightjs#3917
15674e2 to
be838a1
Compare
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +69 B View Changes
|
joshgoebel
approved these changes
Nov 3, 2023
wolfgang42
added a commit
to wolfgang42/highlight.js
that referenced
this pull request
Mar 31, 2025
This reverts commit d78749a.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In POSIX shells, the
#needs to be after a whitespace or start-of-line to delimit a comment. Compare:This is fixed with this PR.
I checked a few other languages as well that use #-delimited comments, but it seems this behaviour is unique to bash and other POSIX shells.
Fixes #3917
Changes
Inside the bash mode,
HASH_COMMENT_MODEwas wrapped in another mode that prevents a match if the#is not after the start of the line or a whitespace character.Checklist
CHANGES.md