This repository was archived by the owner on Oct 3, 2020. It is now read-only.
Add VERIFY_CERT to allow cert verification to be turned off #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are use cases where cert verifcation might not be used; when using only a token to access a cluster, I get a SSLError since the cert if self signed. This adds a flag to turn off verification.
1d4ad65 to
ac99b3c
Compare
|
First of all thanks for the nice words and the PR! 😄 Regarding the PR: I would move the logic into the cluster discovery as you might have different clusters, some with proper cert and some not; also the kubeconfig supports the |
|
Ahh nice didn't notice that. I'll take a look. Thanks! |
|
Will be obsolete with #209 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for the awesome app. This made my life much easier this week, managing 5 clusters. To simplify testing and early deployment, I'd like to be able to disable cert verification against the master. Clearly not something we'd want to suggest everyone do but it's much easier for me to generate a service account token and point it at a cluster, then passing around a CA as well.
I was debating between:
So if you have a preference, let me know!