Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: BPS-1256 ensure the verification tests are passing on IDAM side #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akomisarek merged 2 commits into from
Sep 15, 2020
Merged

fix: BPS-1256 ensure the verification tests are passing on IDAM side #111

akomisarek merged 2 commits into from
Sep 15, 2020

Conversation

@akomisarek
Copy link
Contributor

@akomisarek akomisarek commented Sep 14, 2020 •
edited
Loading

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/BPS-1256

Change description

  • the fix removes broken PACT, which doesn't have appropriate state in IDAM
  • the PACT consumer version is bumped so charset=UTF-8 is optional in the application/json portion
[ ] Yes
[ ] No

@akomisarek akomisarek marked this pull request as draft September 14, 2020 16:29
@akomisarek akomisarek force-pushed the dev/fix-idam-content-type-verification-failure branch 2 times, most recently from 7dfdc4a to 9a5a24d Compare September 15, 2020 13:02
fix: BPS-1256 ensure the verification tests are passing on IDAM side
04666fb 
* the fix removes broken PACT, which doesn't have appropriate state in IDAM
* the PACT consumer is bumped so charset=UTF-8 is optional in the application/json portion
@akomisarek akomisarek force-pushed the dev/fix-idam-content-type-verification-failure branch from 9a5a24d to 04666fb Compare September 15, 2020 13:07
@akomisarek akomisarek marked this pull request as ready for review September 15, 2020 14:34
@akomisarek
Copy link
Contributor Author

akomisarek commented Sep 15, 2020

@smathangi - I am merging this one, which removes your test, but now the verifications are green.

If you need I can help you how to run the verifications.

@akomisarek akomisarek merged commit 537e848 into master Sep 15, 2020
@akomisarek akomisarek deleted the dev/fix-idam-content-type-verification-failure branch September 15, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rkondratowicz rkondratowicz rkondratowicz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akomisarek @rkondratowicz