Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update spring dependencies #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
linusnorton merged 3 commits into from
Feb 4, 2021
Merged

update spring dependencies #140

linusnorton merged 3 commits into from
Feb 4, 2021

Conversation

@linusnorton
Copy link
Contributor

@linusnorton linusnorton commented Feb 4, 2021 •
edited
Loading

Updating the spring packages to 2.4 / spring cloud 2020.0.1

Note that this change may be backwards incompatible depending how you have configured feign. I needed to update the feign configuration to scan the uk.gov.hmcts.reform.idam package otherwise it would ignore the IdamApi provided:

@EnableFeignClients(basePackages = {"uk.gov.hmcts.reform.divorce", "uk.gov.hmcts.reform.idam"})
@SpringBootApplication(scanBasePackages = {"uk.gov.hmcts.reform.divorce",
    "uk.gov.hmcts.reform.logging.appinsights" } ,
    exclude = {ServiceAuthAutoConfiguration.class})
public class CaseMaintenanceServiceApplication {

@linusnorton linusnorton changed the title update spring dependencies [DONT MERGE] update spring dependencies Feb 4, 2021
@linusnorton linusnorton changed the title [DONT MERGE] update spring dependencies update spring dependencies Feb 4, 2021
@timja
Copy link
Contributor

timja commented Feb 4, 2021

Actually can you update the docs? they don't mention needing to enable feign clients manually.

I assume you haven't found a way around that? I think we have that annotation in the client and maybe it doesn't scan libs any more for it =/

@linusnorton
Copy link
Contributor Author

linusnorton commented Feb 4, 2021

That's right, I'll update the docs. I assume this will need to be a major version bump so that it doesn't catch people out.

@timja timja added breaking dependencies Pull requests that update a dependency file labels Feb 4, 2021
@linusnorton linusnorton merged commit fb3450b into master Feb 4, 2021
@linusnorton linusnorton deleted the update_spring branch February 4, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@nitinprabhu nitinprabhu nitinprabhu approved these changes

@timja timja timja approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@linusnorton @timja @nitinprabhu