-
Notifications
You must be signed in to change notification settings - Fork 3
SSCS-7574 Pact tests Configuration #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SSCS-7574 Setup Pact for Idam Client formatting
|
The pact is failing when verified by Idam currently: |
| .uponReceiving("Provider takes user/pwd and returns Auth code to Idam Client") | ||
| .path(IDAM_OPENID_TOKEN_URL) | ||
| .method(HttpMethod.POST.toString()) | ||
| .body("redirect_uri=https%3A%2F%2Flocalhost%3A5000%2Freceiver&client_id=bsp&grant_type=password" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this work when idam tries to verify the pact?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the above was running provider pact verification locally against idam-api. The test I've added is on par with the em-annotations one which is passing. Based on that I'm confident the test as of this today is correct.
Making publishing a consumer pact test PR dependent dependent on provider running and verifying against prod pipeline definitely feels like a bad pattern. If someone wants to extend a provider verification step for consumer prs that's fine but beyond scope of this PR
| @@ -0,0 +1,16 @@ | |||
| #!groovy | |||
|
|
|||
| @Library("Infrastructure@SSCS-7575") | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to update this when the jenkins-library pr is merged



Before creating a pull request make sure that:
Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")