Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@danhamilton
Copy link
Contributor

Before creating a pull request make sure that:

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:

JIRA link (if applicable)

Change description

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

SSCS-7574 Setup Pact for Idam Client

formatting
@timja timja changed the title Sscs 7574 SSCS-7574 Pact tests Jun 15, 2020
@timja
Copy link
Contributor

timja commented Jun 15, 2020

The pact is failing when verified by Idam currently:

image

https://pact-broker.platform.hmcts.net/

@danhamilton danhamilton changed the title SSCS-7574 Pact tests SSCS-7574 Pact tests Configuration Jun 16, 2020
.uponReceiving("Provider takes user/pwd and returns Auth code to Idam Client")
.path(IDAM_OPENID_TOKEN_URL)
.method(HttpMethod.POST.toString())
.body("redirect_uri=https%3A%2F%2Flocalhost%3A5000%2Freceiver&client_id=bsp&grant_type=password"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this work when idam tries to verify the pact?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now working when running Pact provider verify for idam-api.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed 23 hours ago but maybe need idam to re-run verification?

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the above was running provider pact verification locally against idam-api. The test I've added is on par with the em-annotations one which is passing. Based on that I'm confident the test as of this today is correct.

Making publishing a consumer pact test PR dependent dependent on provider running and verifying against prod pipeline definitely feels like a bad pattern. If someone wants to extend a provider verification step for consumer prs that's fine but beyond scope of this PR

@danhamilton danhamilton requested a review from satyachundur June 17, 2020 14:37
@danhamilton danhamilton merged commit b731b73 into master Jun 18, 2020
@danhamilton danhamilton deleted the SSCS-7574 branch June 18, 2020 07:42
@@ -0,0 +1,16 @@
#!groovy

@Library("Infrastructure@SSCS-7575")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to update this when the jenkins-library pr is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants