Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@danhamilton
Copy link
Contributor

Before creating a pull request make sure that:

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/SSCS-7729

Change description

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

@danhamilton danhamilton requested a review from timja June 26, 2020 15:32
Copy link
Contributor

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danhamilton
Copy link
Contributor Author

@timja - looks like there's multiple ways to specify this. Feeding it off idam.api config allows us to group the config with existing conf which I think is obvious to navigate for services using the library

@danhamilton danhamilton merged commit 1e9f74e into master Jun 26, 2020
@danhamilton danhamilton deleted the SSCS-7729 branch June 26, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants