Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ACA-46 idam searchUsers api #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smathangi merged 3 commits into from
Jul 22, 2020
Merged

ACA-46 idam searchUsers api #97

smathangi merged 3 commits into from
Jul 22, 2020

Conversation

@smathangi
Copy link
Contributor

@smathangi smathangi commented Jul 20, 2020

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/ACA-46

Change description

Exposed search-api

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ x] No

@smathangi smathangi requested review from doncem and timja July 20, 2020 15:29
@smathangi smathangi changed the title ACA-46 idam search-api ACA-46 idam searchUsers api Jul 20, 2020
timja
timja reviewed Jul 21, 2020
View reviewed changes
Copy link
Contributor

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you plan to write a pact test for this?
https://github.com/hmcts/idam-java-client/tree/master/src/contractTest

(you might want to fix the directory structure if you are changing it, it's a single directory with .'s atm)

@smathangi
Copy link
Contributor Author

smathangi commented Jul 22, 2020

do you plan to write a pact test for this?
https://github.com/hmcts/idam-java-client/tree/master/src/contractTest

(you might want to fix the directory structure if you are changing it, it's a single directory with .'s atm)

sure, will write one. What's the directory structure I've to fix ?

@timja
Copy link
Contributor

timja commented Jul 22, 2020

a mistake was made in the PR that created the contract test, it's one folder with .'s in it

image

timja
timja approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the pact test only runs on master, can you please verify it after merge?

@smathangi
Copy link
Contributor Author

smathangi commented Jul 22, 2020

Looks like the pact test only runs on master, can you please verify it after merge?

sure, looks like master is broken atm (pactPublish failure)

@smathangi smathangi merged commit 144877a into master Jul 22, 2020
@smathangi smathangi deleted the ACA-46 branch July 22, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doncem doncem Awaiting requested review from doncem

1 more reviewer

@timja timja timja approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smathangi @timja