Dropping support for Bokeh 2 #5891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5891 +/- ##
==========================================
+ Coverage 88.41% 88.56% +0.15%
==========================================
Files 312 313 +1
Lines 64953 65069 +116
==========================================
+ Hits 57427 57628 +201
+ Misses 7526 7441 -85
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 35 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
9190f06 to
d2fd3e4
Compare
philippjfr
approved these changes
Oct 11, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5751 removed Bokeh 2 from the test suite.
This PR continues it and removes support from the code base.
The sorting of import will be done in another PR, where I will enable automatic linting for it.