Adds Bokeh 3.5 enhancements to RangeToolLink #6341
Conversation
|
@holoviz-developers, I'm seeking feedback on default styling of box handles and inverted highlighting e.g.: tool.overlay.handles.all.hover_fill_color = "grey"
tool.overlay.handles.all.hover_fill_alpha = 0.25
tool.overlay.handles.all.hover_line_alpha = 0
tool.overlay.handles.all.fill_alpha = 0.1
tool.overlay.handles.all.line_alpha = 0.25 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6341 +/- ##
==========================================
+ Coverage 88.48% 88.49% +0.01%
==========================================
Files 323 323
Lines 68162 68179 +17
==========================================
+ Hits 60313 60337 +24
+ Misses 7849 7842 -7 ☔ View full report in Codecov by Sentry. |
|
Styling looks good to me! |
|
@hoxbro , is this good to merge? |
holoviews/plotting/links.py
Outdated
| use_handles = param.Boolean(default=True, doc=""" | ||
| Whether to display handles""") | ||
|
|
||
| start_gesture = param.ObjectSelector(default='tap', objects=['pan', 'tap', 'none'], | ||
| doc="""Gesture to start a range selection""") | ||
|
|
||
| inverted = param.Boolean(default=True, doc=""" | ||
| Whether to invert the highlighting of the range selection""") |
There was a problem hiding this comment.
Maybe add information that this is only available from Bokeh 3.5
There was a problem hiding this comment.
I added a note in each of the docstrings
I added a warning if bokeh34. Is this what you are suggesting? if bokeh34:
warn("RangeTool styling and interactivity options updated in Bokeh 3.5.") |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Closes #6340
GMT20240724-192251_Clip_Demetris.Roumis.s.Clip.07_24_2024.mp4