Thanks to visit codestin.com
Credit goes to github.com

Skip to content

compat: cuDF 25.08 #6659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

compat: cuDF 25.08 #6659

wants to merge 1 commit into from

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Aug 7, 2025 •
edited
Loading

image

hoxbro
hoxbro commented Aug 7, 2025
View reviewed changes
holoviews/core/data/cudf.py
@@ -255,7 +255,7 @@ def select(cls, dataset, selection_mask=None, **selection):

indexed = cls.indexed(dataset, selection)
if selection_mask is not None:
df = df.iloc[selection_mask]
df = df.loc[selection_mask]
Copy link
Member Author

@hoxbro hoxbro Aug 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Else test would error:

.pixi/envs/test-gpu/lib/python3.12/site-packages/cudf/core/indexing_utils.py:118: KeyError
=================================================================================================================== short test summary info ===================================================================================================================
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_groupby - KeyError: '0     True\n1     True\n2    False\nName: Gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_groupby_alias - KeyError: '0     True\n1     True\n2    False\nName: gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_groupby_dynamic - KeyError: '0     True\n1     True\n2    False\nName: Gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_groupby_dynamic_alias - KeyError: '0     True\n1     True\n2    False\nName: gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_groupby_second_dim - KeyError: '0     True\n1    False\n2    False\nName: Age, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_index_column_idx_hm - KeyError: '0     False\n1     False\n2     False\n3     False\n4     False\n5      True\n6     False\n7     False\n8     False\n9     False\n10    False\nName: x, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_index_item_table - KeyError: '0    False\n1    False\n2     True\ndtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_index_row_age - KeyError: '0    False\n1    False\n2     True\nName: Age, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_index_row_gender_female - KeyError: '0    False\n1    False\n2     True\nName: Gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_index_rows_gender_male - KeyError: '0     True\n1     True\n2    False\nName: Gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_index_value1 - KeyError: '0    False\n1    False\n2     True\ndtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_index_value2 - KeyError: '0    False\n1    False\n2     True\ndtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_select_rows_gender_male - KeyError: '0     True\n1     True\n2    False\nName: Gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_select_rows_gender_male_alias - KeyError: '0     True\n1     True\n2    False\nName: gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_select_rows_gender_male_alias_dict - KeyError: '0     True\n1     True\n2    False\nName: gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_select_rows_gender_male_dict - KeyError: '0     True\n1     True\n2    False\nName: Gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_select_rows_gender_male_dimension_dict - KeyError: '0     True\n1     True\n2    False\nName: Gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_select_rows_gender_male_expr - KeyError: '0     True\n1     True\n2    False\nName: Gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_slice_fn_hm - KeyError: '0     False\n1     False\n2     False\n3     False\n4     False\n5      True\n6      True\n7      True\n8      True\n9     False\n10    False\nName: x, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_slice_hm - KeyError: '0     False\n1     False\n2     False\n3     False\n4     False\n5      True\n6      True\n7      True\n8      True\n9     False\n10    False\nName: x, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_slice_hm_alias - KeyError: '0     False\n1     False\n2     False\n3     False\n4     False\n5      True\n6      True\n7      True\n8      True\n9     False\n10    False\nName: x, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_value_dim_scalar_index - KeyError: '0     True\n1    False\n2    False\ndtype: bool: boolean label can not be used without a boolean index'
=========================================================================================== 22 failed, 105 passed, 1 skipped, 5471 deselected, 2 xfailed in 13.28s ============================================================================================

@codecov Codecov
Copy link

codecov bot commented Aug 7, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.92%. Comparing base (bd6c739) to head (cb6ef49).

Files with missing lines Patch % Lines
holoviews/core/data/cudf.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6659   +/-   ##
=======================================
  Coverage   88.92%   88.92%           
=======================================
  Files         328      328           
  Lines       70020    70020           
=======================================
  Hits        62262    62262           
  Misses       7758     7758

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hoxbro hoxbro marked this pull request as ready for review August 7, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hoxbro