fix: setting selection_expr programmatically
#6689
Open
+18
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
selection_expr programmatically
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6689 +/- ##
==========================================
+ Coverage 89.02% 89.03% +0.01%
==========================================
Files 329 329
Lines 70389 70443 +54
==========================================
+ Hits 62661 62721 +60
+ Misses 7728 7722 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hoxbro
reviewed
Sep 11, 2025
Comment on lines
+398
to
+403
| try: | ||
| inst._selection_override.event(selection_expr=new_selection_expr) | ||
| inst._cross_filter_stream.selection_expr = new_selection_expr | ||
| finally: | ||
| with param.parameterized.discard_events(inst): | ||
| inst.show_regions = True |
There was a problem hiding this comment.
Not sure why this has been indented and why the try/finally is needed.
Should there be a special case for inst.show_regions = True when new_selection_expr is None?
| @@ -175,6 +175,18 @@ def test_layout_selection_points_table(self): | |||
| ] | |||
| ) | |||
|
|
|||
| def test_select_expr_show_regions(self): | |||
There was a problem hiding this comment.
I think we need a UI test for this change.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6687, fixes #6688
HoloViews.linked_selections.fix.mp4