Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix .hist for ibis backend #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 10, 2023
Merged

Fix .hist for ibis backend #997

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b7a75b2
fix ibis
Nov 26, 2022
818c640
support python 3.6
Nov 26, 2022
1ce44cd
wip fix hist for ibis
MarcSkovMadsen Dec 1, 2022
27c1f67
fix flake
MarcSkovMadsen Dec 1, 2022
a04dde7
fix matplotlib + test x types
MarcSkovMadsen Dec 1, 2022
58c7dd5
wip
MarcSkovMadsen Dec 2, 2022
726266f
wip
MarcSkovMadsen Dec 2, 2022
9fa7500
Merge branch 'master' of https://github.com/holoviz/hvplot into fix/hist
MarcSkovMadsen Dec 3, 2022
7f0caba
Merge branch 'main' into fix/hist
maximlt Oct 8, 2023
302a892
simplify the tests
maximlt Oct 8, 2023
42aafda
clean up
maximlt Oct 8, 2023
a5f2e40
set backend
maximlt Oct 8, 2023
7c37735
Merge branch 'main' into fix/hist
maximlt Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' of https://github.com/holoviz/hvplot into fix/hist
  • Loading branch information
@MarcSkovMadsen
MarcSkovMadsen committed Dec 3, 2022
commit 9fa75003ef74470ef51444c359a2c47c0ae54527
15 changes: 2 additions & 13 deletions hvplot/tests/testibis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import holoviews as hv
import matplotlib
import pandas as pd
import pytest

matplotlib.use('agg')
Expand All @@ -13,7 +14,6 @@
import hvplot.ibis # noqa
import hvplot.pandas # noqa
import ibis
import pandas as pd
except:
pytest.skip(allow_module_level=True)

Expand Down Expand Up @@ -51,18 +51,7 @@ def ibis_duckdb_data(df: pd.DataFrame, *args, **kwargs):

return ibis.duckdb.connect(filename).table("df")

class IbisMemConnection(param.Parameterized):
def __init__(self, df):
super().__init__()
self._table = ibis.memtable(df)

def table(self, df):
return self._table

def ibis_mem_table(df: pd.DataFrame, *args, **kwargs):
return IbisMemConnection(df=df)

@pytest.fixture(params=[pandas_data, ibis_pandas_data, ibis_duckdb_data, ibis_sqlite_data, ibis_mem_table])
@pytest.fixture(params=[pandas_data, ibis_pandas_data, ibis_duckdb_data, ibis_sqlite_data])
def data(request, reference_df, tmpdir):
return request.param(reference_df, tmpdir=tmpdir)

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.