Clean up core #10305
Merged
Clean up core #10305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 3, 2017
| 'post_pending_state', | ||
| STATE_ALARM_ARMED_NIGHT)) | ||
| state = self.hass.states.get(entity_id) | ||
| assert state.attributes['post_pending_state'] == STATE_ALARM_ARMED_NIGHT |
| 'post_pending_state', | ||
| STATE_ALARM_ARMED_NIGHT)) | ||
| state = self.hass.states.get(entity_id) | ||
| assert state.attributes['post_pending_state'] == STATE_ALARM_ARMED_NIGHT |
homeassistant/helpers/template.py
Outdated
| """Test if a state is a specific attribute.""" | ||
| state_obj = self.hass.states.get(entity_id) | ||
| return state_obj is not None and \ | ||
| state_obj.attributes.get(name, None) == value |
There was a problem hiding this comment.
Why specify None as default?
There was a problem hiding this comment.
Because I copied it from core. Fixed.
pvizeli
approved these changes
Nov 3, 2017
pvizeli
approved these changes
Nov 3, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
is_state_attrfromhass.states. This should never have been added. It's a helper method that has not much value in core. I've made sure that it is still available for templates.waitvariable fromhass.bus.async_fireBreaking change:
hass.states.is_state_attrhas been removedwaithas been removed ofhass.bus.async_fireChecklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass