Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Starlink consumption sensors #132262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Dec 9, 2024
Merged

Add Starlink consumption sensors #132262

merged 25 commits into from
Dec 9, 2024

Conversation

davidrapan
Copy link
Contributor

@davidrapan davidrapan commented Dec 4, 2024 •
edited
Loading

Proposed change

Add power and energy sensors which are exposed in starlink-grpc-core since version 1.2.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Dec 4, 2024

Hey there @boswelja, mind taking a look at this pull request as it has been labeled with an integration (starlink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of starlink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign starlink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@edenhaus edenhaus changed the title Starlink consumption Add Starlink consumption sensors Dec 4, 2024
@davidrapan
Copy link
Contributor Author

Check mypy should not complain about:

Python 3.12.7
Error: homeassistant/components/starlink/coordinator.py:68: error: Too many arguments for "StarlinkData"  [call-arg]

but python/mypy#14648

joostlek
joostlek requested changes Dec 4, 2024
View reviewed changes
@home-assistant home-assistant bot marked this pull request as draft December 4, 2024 19:23
@home-assistant
Copy link

home-assistant bot commented Dec 4, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@davidrapan davidrapan requested a review from joostlek December 4, 2024 19:33
boswelja
boswelja reviewed Dec 4, 2024
View reviewed changes
@davidrapan davidrapan requested a review from boswelja December 5, 2024 00:23
@davidrapan davidrapan marked this pull request as ready for review December 5, 2024 00:51
@davidrapan davidrapan mentioned this pull request Dec 9, 2024
Merged
8 tasks
joostlek
joostlek requested changes Dec 9, 2024
View reviewed changes
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruff is failing, can you take a look?

@home-assistant home-assistant bot marked this pull request as draft December 9, 2024 10:15
@davidrapan
Copy link
Contributor Author

davidrapan commented Dec 9, 2024 •
edited
Loading

Yes I already mentioned it here: #132262 (comment)

I mean I could rearange the dataclass but I did not wanted to touch and change existing code, just add.

Edit: Oh it's about something else now too...

Edit2: But mypy will still fail so do you want me to rearange the dataclass? Mypy does not like unpacking in between arguments...

@joostlek
Copy link
Member

joostlek commented Dec 9, 2024

I don't mind rearranging the dataclass, as long as it works and looks nice :P

davidrapan
davidrapan commented Dec 9, 2024
View reviewed changes
@joostlek
Copy link
Member

joostlek commented Dec 9, 2024

But now the tests are failing :P

joostlek
joostlek reviewed Dec 9, 2024
View reviewed changes
@davidrapan davidrapan requested a review from joostlek December 9, 2024 11:51
@joostlek
Copy link
Member

joostlek commented Dec 9, 2024

Prettier is failing now

@davidrapan
Copy link
Contributor Author

davidrapan commented Dec 9, 2024 •
edited
Loading

Is it bc of 0.0?

@davidrapan
Copy link
Contributor Author

davidrapan commented Dec 9, 2024 •
edited
Loading

I'm baffled, what it does not like?

Edit: Nvm I see it now.

@joostlek
Copy link
Member

joostlek commented Dec 9, 2024

Do you have a dev env setup? pre-commit should automatically pick this up and fix it for you

@joostlek
Copy link
Member

joostlek commented Dec 9, 2024

Please fix the issues locally in a development environment. I don't want to keep running the CI

@davidrapan
Copy link
Contributor Author

It's all ✅ now! Sorry for this lengthy process, it's my first time. :P

@joostlek joostlek merged commit 21a2ce6 into home-assistant:dev Dec 9, 2024
34 checks passed
@davidrapan davidrapan deleted the starlink-consumption branch December 9, 2024 15:34
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek approved these changes

@boswelja boswelja Awaiting requested review from boswelja

Assignees
No one assigned
Labels
cla-signed integration: starlink new-feature Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add momentary power usage and total power usage for starlink
3 participants
@davidrapan @joostlek @boswelja