Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add notify platform to template integration #147220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Add notify platform to template integration #147220

wants to merge 1 commit into from

Conversation

Petro31
Copy link
Contributor

@Petro31 Petro31 commented Jun 20, 2025

Breaking change

Proposed change

Add the notify platform to template integration.

template:
- notify:
  - name: ....

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Petro31 Petro31 requested a review from a team as a code owner June 20, 2025 13:43
@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (template) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of template can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign template Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@Petro31 Petro31 marked this pull request as draft June 20, 2025 13:43
@Petro31
Copy link
Contributor Author

Petro31 commented Jun 20, 2025

This PR is quite a ways off from being complete. It seems like upstream notify platform changes are needed for this to get implemented into the template integration. The legacy handling in the notify platform throw wrenches in to the current way platforms are created in the template integration.

Because there is no overall config entry for the template integration, we cannot use async_setup_entry and we are forced to use async_setup_platform which causes all sorts of problems for the notify platform.

@Petro31
Copy link
Contributor Author

Petro31 commented Jun 20, 2025

Also, just for notes:

  • Need to add tests for send_message with and without a title.
  • Need to add blueprint test
  • Need upstream notify changes (or other solution to previous comment).

@arturpragacz
Copy link
Contributor

Would it make sense to add them as UI-only for now? That way you sidestep the async_setup_platform problem.

@Petro31
Copy link
Contributor Author

Petro31 commented Jun 20, 2025 •
edited
Loading

Would it make sense to add them as UI-only for now? That way you sidestep the async_setup_platform problem.

I could do that for sure. That's already tested and appears to work for the most part. I'll have to mull that over.

Thinking out loud here:

We wouldn't be able to template name, picture, icon. No trigger based.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: template new-feature new-platform Quality Scale: internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Petro31 @arturpragacz