-
-
Notifications
You must be signed in to change notification settings - Fork 34.1k
Expose Songpal enumTarget settings via select entities #147230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
YoshiWalsh
wants to merge
17
commits into
home-assistant:dev
Choose a base branch
from
YoshiWalsh:songpal-select-entities
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Expose Songpal enumTarget settings via select entities #147230
YoshiWalsh
wants to merge
17
commits into
home-assistant:dev
from
YoshiWalsh:songpal-select-entities
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also prepares re-usable functionality which will be used to create additional entities to expose various Songpal settings. Since this is a significant refactoring, I have also added myself to the codeowners list to indicate my willingness to provide ongoing support.
Hey there @rytilahti, @shenxn, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8 tasks
This will be split into a separate PR
aa12359
to
efa45ed
Compare
I didn't mean to commit these in the first place oops
Adds typing and removes unnecessary dataclass
…to songpal-coordinator-refactor
efa45ed
to
42b2784
Compare
42b2784
to
be6424f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Based on feedback for #147217 I have split my contribution into multiple smaller PRs. This is PR 4/6. PR #147237 should be merged first!
This PR:
Adds select entities for enumTarget settings
Overall changes: (across all 6 PRs)
With these changes, additional entities are created to expose enum, boolean, string, and integer settings based on whatever the Songpal device supports.
My motivation for making this was because I wanted to be able to control night mode, voice enhancement, and subwoofer level from Home Assistant.
Before:

After:

The additional entities may differ from device to device, so are generated dynamically based on what python-songpal reports as available.
(I don't expose playback_settings because these settings are duplicated for each input source, which seemed a bit messy. I also don't expose speaker_settings because it was giving me an Invalid Argument error and so was impossible for me to test with my device.)
I believe this change maintains backwards compatibility (existing entity unique IDs should not change, existing services are conserved).
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: