Fix unit conversion #14730
Merged
Fix unit conversion #14730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 31, 2018
|
|
||
| return DEFAULT_MAX_TEMP | ||
| return convert_temperature(self._max_temp, self._unit, | ||
| hass.config.units.temperature_unit) |
|
|
||
| return DEFAULT_MIN_TEMP | ||
| return convert_temperature(self._min_temp, self._unit, | ||
| hass.config.units.temperature_unit) |
3 tasks
balloob
reviewed
Jun 7, 2018
| @@ -268,7 +267,8 @@ def min_temp(self): | |||
| if self._min_temp: | |||
| return self._min_temp | |||
|
|
|||
| return DEFAULT_MIN_TEMP | |||
| # get default temp from super class | |||
| return ClimateDevice.min_temp.fget(self) | |||
There was a problem hiding this comment.
Why can't you call super().min_temp like you do in the other platforms?
There was a problem hiding this comment.
I was just reverting to the previous version... but I agree with your comment, will do the change
|
btw impressive that you managed to open a PR 7 days ago with a fix for a PR I merged 3 hours ago 😝 |
|
Thats how long ago I noticed the issue (during review) and prepared this :) |
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* reviewing this code min_temp and max_temp are always present and always in celsius * revert change (preserve unit conversion) * revert (due to unit conversion) * self * clean * cleaner
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In a previous accepted PR #14690 a bug was introduced when global HA temperature unit in Fahrenheit.
This PR reverts changes in generic_thermostat and sensible, but re-engineers tado, since tado always has a min_temp/max_temp and doesn't require the DEFAULT_*.
Related issue (if applicable): fixes #14690
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: