Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix non awaited test #14854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2018
Merged

Fix non awaited test #14854

merged 1 commit into from
Jun 7, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Jun 7, 2018

Description:

Whenever we would run the tests, we had a warning that one test method was never awaited.

This PR fixes that.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant homeassistant added small-pr PRs with less than 30 lines. cla-signed labels Jun 7, 2018
@ghost ghost assigned balloob Jun 7, 2018
@ghost ghost added the in progress label Jun 7, 2018
fabaff
fabaff approved these changes Jun 7, 2018
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐦

@fabaff fabaff merged commit bf74cab into dev Jun 7, 2018
@ghost ghost removed the in progress label Jun 7, 2018
@fabaff fabaff deleted the fix-non-awaited-test branch June 7, 2018 13:58
@balloob balloob mentioned this pull request Jun 22, 2018
Merged
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@balloob
Fix non awaited test (home-assistant#14854)
a5b4133
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees

@balloob balloob

Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balloob @fabaff @homeassistant