UVC camera platform handling unavailable NVR or cameras better #14864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g tests must be separated out to ensure that the setup_component call is actually executed
…y recoverable cases; added tests
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
…assistant#14864) * fixed tests: using correct camera configuration now and error handling tests must be separated out to ensure that the setup_component call is actually executed * better error handling during setup; raising PlatformNotReady in likely recoverable cases; added tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #14838 by surrounding all interactions with the NVR or cameras into a try-block and catching and handling any exceptions during the initial setup of the component. Also, raising
PlatformNotReadyin those cases that are likely recoverable to make HA try the setup again after 30 seconds. Some test cases corrected that were previously wrong (but not failing). Some test cases modified and some added to test the modified or new functionality.Related issue (if applicable): fixes #14838
Pull request in home-assistant.github.io with documentation (if applicable): n/a
Example entry for
configuration.yaml(if applicable): n/aChecklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: