Make RainMachine async #14879
Merged
Make RainMachine async #14879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| async def refresh_sensors(event_time): | ||
| """Refresh RainMachine sensor data.""" | ||
| _LOGGER.debug('Updating RainMachine sensor data') | ||
| await hass.data[DATA_RAINMACHINE].async_update() |
There was a problem hiding this comment.
rainmachine is directly accessible here so no need to access the dict to get it.
| @@ -20,7 +20,10 @@ | |||
| _LOGGER = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| def setup_platform(hass, config, add_devices, discovery_info=None): | |||
| async def async_setup_platform(hass, | |||
There was a problem hiding this comment.
Please break line after the parenthesis instead, and fill out as much as possible of the line. That's more in line with home assistant style.
There was a problem hiding this comment.
FYI, I found a lot of other style inconsistencies based on your above request, so I went ahead and addressed them.
|
@MartinHjelmare 3.6 was a mistake on my part; changed the library to require 3.5 as the minimum. Thanks for catching! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR:
regenmaschine) to 1.0.1.Related issue (if applicable): N/A
Pull request in home-assistant.github.io with documentation (if applicable): N/A
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated in home-assistant.github.ioIf the code communicates with devices, web services, or third-party tools:
- [ ] New dependencies have been added to theREQUIREMENTSvariable (example).- [ ] New dependencies are only imported inside functions that use them (example).- [ ] New or updated dependencies have been added torequirements_all.txtby runningscript/gen_requirements_all.py.- [ ] New files were added to.coveragerc.