-
-
Notifications
You must be signed in to change notification settings - Fork 34.1k
pytradfri 5.5.1: Improved 3rd party bulb support #14887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pvizeli
merged 9 commits into
home-assistant:dev
from
Hate-Usernames:tradfri-combine-commands
Jun 13, 2018
Merged
pytradfri 5.5.1: Improved 3rd party bulb support #14887
pvizeli
merged 9 commits into
home-assistant:dev
from
Hate-Usernames:tradfri-combine-commands
Jun 13, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP until 5.5 is released to PyPI |
b587696
to
91ab7e6
Compare
0c5a7a9
to
b79a7c5
Compare
pvizeli
approved these changes
Jun 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work !
Merged
Hey, my issue #14554 was closed by this PR, but I still reproduce the exact same problem. Any chance my issue could be re-open? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes #14565, fixes #14525, fixes #14554
Example entry for
configuration.yaml
(if applicable):tradfri:
Checklist:
tox
. Your PR cannot be merged unless tests passIf the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: